Skip to content

Conversation

@marianogappa
Copy link
Contributor

The ClickHouse console allows one to quote table names using single quotes:

Screenshot 2025-10-02 at 16 19 25

The parser does not:

Screenshot 2025-10-02 at 16 21 55

This PR implements support for this. Adds test for it; all other tests continue to pass.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18192806267

Details

  • 26 of 28 (92.86%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 50.292%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_common.go 18 20 90.0%
Totals Coverage Status
Change from base Build 18089258850: 0.06%
Covered Lines: 7402
Relevant Lines: 14718

💛 - Coveralls

@git-hulk git-hulk merged commit c884bd5 into AfterShip:master Oct 2, 2025
2 checks passed
@git-hulk
Copy link
Member

git-hulk commented Oct 2, 2025

@marianogappa Thanks for your great improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants